-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use evmc::MockedHost moar #7831
Conversation
If these things are part of EVMC anyway, then we should use them! |
It was added lately: ethereum/evmc#334 |
Some older clang fails on this: https://travis-ci.org/ethereum/solidity/jobs/618167425 |
Rebased on develop and fixed my original commit message. Before merging, we should update to EVMC master which:
|
6e1c67d
to
0210080
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Compared to #7854, which ran It is a 7% time reduction. |
This reuses some data structs and features already defined in
evmc::MockedHost
inEVMHost
implementation. It is up to discussion if this should be continued and if the direction is right in general.Depends on #7848.